Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refresh snooze after action #2223

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Mar 5, 2025

Don't forget to refresh the snooze folder after an action has been triggered on an inbox message. By default, this wasn't working because it wasn't ever expected that message with a uid of a folder might want to refresh other folders.

Also, do we want to rename variables of the new ImpactedFolder type?

Depends on #2236

@LunarX LunarX added the enhancement Improve or expand upon an existing feature label Mar 5, 2025
@LunarX LunarX requested a review from KevinBoulongne March 5, 2025 14:30
@LunarX LunarX self-assigned this Mar 5, 2025
@github-actions github-actions bot added the dependent This MR depends on another PR label Mar 5, 2025
@LunarX LunarX force-pushed the refresh-snooze-after-action branch from 6909d11 to ae26455 Compare March 6, 2025 07:26
@LunarX LunarX force-pushed the refresh-strategy-for-deleted branch from b1042da to 2b7f41d Compare March 6, 2025 07:26
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from 2b7f41d to e7ea42e Compare March 6, 2025 13:32
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from ae26455 to abb7b41 Compare March 6, 2025 13:34
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from e7ea42e to 332316b Compare March 6, 2025 14:00
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from abb7b41 to 596b66e Compare March 6, 2025 14:00
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from 332316b to e49d531 Compare March 7, 2025 07:44
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from 596b66e to dad78c5 Compare March 7, 2025 07:44
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from e49d531 to b95d1b0 Compare March 7, 2025 08:20
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from dad78c5 to 1b11c8c Compare March 7, 2025 08:20
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from b95d1b0 to f203493 Compare March 7, 2025 08:36
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from 1b11c8c to f0a8c9f Compare March 7, 2025 08:36
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch 3 times, most recently from 58617df to fc73910 Compare March 7, 2025 09:47
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch 2 times, most recently from d1d7d61 to 6a51854 Compare March 7, 2025 12:16
@KevinBoulongne KevinBoulongne changed the base branch from refresh-strategy-for-deleted to message-initLocalValues March 7, 2025 12:16
@KevinBoulongne KevinBoulongne force-pushed the message-initLocalValues branch 2 times, most recently from 0b40d83 to 2172c7b Compare March 7, 2025 12:21
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from 6a51854 to 68ea208 Compare March 7, 2025 13:01
@KevinBoulongne KevinBoulongne force-pushed the message-initLocalValues branch from b0053f3 to 6b21ef2 Compare March 10, 2025 13:30
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from 68ea208 to fc91ad3 Compare March 10, 2025 13:30
@KevinBoulongne KevinBoulongne force-pushed the message-initLocalValues branch from 6b21ef2 to 5a5601e Compare March 10, 2025 16:23
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from fc91ad3 to d063bea Compare March 10, 2025 16:24
@KevinBoulongne KevinBoulongne force-pushed the message-initLocalValues branch 3 times, most recently from 528fa95 to 3c96f33 Compare March 11, 2025 09:03
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from d063bea to dd29930 Compare March 11, 2025 09:03
@LunarX LunarX requested a review from KevinBoulongne March 11, 2025 10:37
@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from db24cc1 to d90b818 Compare March 11, 2025 11:10
Base automatically changed from message-initLocalValues to snooze-feature-branch March 11, 2025 12:16
@github-actions github-actions bot removed the dependent This MR depends on another PR label Mar 11, 2025
Copy link

This PR/issue depends on:

@KevinBoulongne KevinBoulongne force-pushed the refresh-snooze-after-action branch from d90b818 to bca8f74 Compare March 11, 2025 12:18
@KevinBoulongne KevinBoulongne disabled auto-merge March 11, 2025 12:21
@KevinBoulongne KevinBoulongne merged commit 7365cae into snooze-feature-branch Mar 11, 2025
4 checks passed
@KevinBoulongne KevinBoulongne deleted the refresh-snooze-after-action branch March 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or expand upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants