fix: Revert "refactor: Tidy up createNewThread() (#2228)"
#2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevincent
approved these changes
Mar 6, 2025
LunarX
force-pushed
the
fix-crash-when-threads-message-dont-mention-themselves
branch
from
1873e03 to
212cbee
Compare
|
LunarX
deleted the
fix-crash-when-threads-message-dont-mention-themselves
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a1c6b84, reversing changes made to dcafc65.
Right now on the very rare occasion where you have a thread composed of messages where messages don't reference all of the other messages of the thread, the fetch algorithm will crash.
This PR reverts the PR that introduced the bug so we keep master clean and we can add the reverted code in a futur PR as the same time as the fix