feat: Global upgrades on reminder - #2273
Draft
killianmathias wants to merge 13 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Enhances reminder handling across storage, API, UI, analytics, and localization.
Changes:
- Adds mark-as-done reminder support.
- Hides internal reminder messages and refines reminder actions.
- Expands analytics and localized feedback.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
MailResources/Localizable/sv.lproj/Localizable.strings |
Adds Swedish completion feedback. |
MailResources/Localizable/pt.lproj/Localizable.strings |
Adds Portuguese completion feedback. |
MailResources/Localizable/pl.lproj/Localizable.strings |
Updates Polish reminder translations. |
MailResources/Localizable/nl.lproj/Localizable.strings |
Adds Dutch completion feedback. |
MailResources/Localizable/nb.lproj/Localizable.strings |
Adds Norwegian completion feedback. |
MailResources/Localizable/it.lproj/Localizable.strings |
Adds Italian completion feedback. |
MailResources/Localizable/fr.lproj/Localizable.strings |
Adds French completion feedback. |
MailResources/Localizable/fi.lproj/Localizable.strings |
Adds Finnish completion feedback. |
MailResources/Localizable/es.lproj/Localizable.strings |
Adds Spanish completion feedback. |
MailResources/Localizable/en.lproj/Localizable.strings |
Adds English completion feedback. |
MailResources/Localizable/el.lproj/Localizable.strings |
Adds Greek completion feedback. |
MailResources/Localizable/de.lproj/Localizable.strings |
Corrects German reminder translations. |
MailResources/Localizable/da.lproj/Localizable.strings |
Adds Danish completion feedback. |
MailCore/Models/Thread.swift |
Filters internal reminder messages. |
MailCore/Models/ReminderAPIResponse.swift |
Models mark-as-done responses. |
MailCore/Models/Message.swift |
Persists reminder display metadata. |
MailCore/Cache/MailboxManager/MailboxManager+Thread.swift |
Adjusts delta and search processing. |
MailCore/Cache/MailboxManager/MailboxManager+Reminder.swift |
Implements mark-as-done handling. |
MailCore/Cache/Actions/ActionsProvider.swift |
Refines reminder action eligibility. |
MailCore/API/MailApiFetcher/MailApiFetcher+Reminder.swift |
Sends mark-as-done requests. |
MailCore/API/MailApiFetcher/MailApiFetchable.swift |
Extends the reminder API contract. |
MailCore/API/Endpoint/Endpoint+Reminder.swift |
Defines the acknowledgement endpoint. |
Mail/Views/Thread/Message/MessageReminderHeaderView.swift |
Adds completion UI and analytics. |
Mail/Views/Thread/Message/MessageBannerHeaderView.swift |
Tracks follow-up actions. |
Mail/Views/Schedule/SendOptionFloatingPanelView.swift |
Tracks reminder and schedule choices. |
Mail/Views/Schedule/SendOptionFloatingPanel.swift |
Tracks panel and visibility actions. |
Mail/Views/Schedule/CustomScheduleButton.swift |
Distinguishes reminder analytics. |
Mail/Views/New Message/Header Cells/ComposeMessageDateHeaderView.swift |
Tracks reminder rescheduling. |
Mail/Views/New Message/ComposeMessageHeaderView.swift |
Tracks reminder cancellation. |
Mail/Views/Bottom sheets/Actions/ActionsPanelViewModifier.swift |
Captures the selected reminder message. |
Mail/Utils/Draft+Reminder.swift |
Clears reminders when visibility is removed. |
| uid = try container.decode(String.self, forKey: .uid) | ||
| messages = try container.decode(List<Message>.self, forKey: .messages) | ||
| messagesToDisplay = messages.filter { !$0.isReaction }.toRealmList() | ||
| messagesToDisplay = messages.filter { !$0.isReaction && !$0.shouldHideReminder }.toRealmList() |
killianmathias
force-pushed
the
feat/reminder-upgrade
branch
from
August 6, 2026 12:34
6cd3adf to
f758ae3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.