Fix race condition on process executing too fast #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right after starting a process we access its status to retrieve its PID. However if the process already finished before accessing the PID then this first call will also return the exit code. This means that when we try to retrieve the exit code when accessing the output then the reported exit code is
-1
indicating it has always been provided in an earlier call.Solution
When accessing the status of the process the exit code is cached in a property . If the value is cached it then overwrite any following value return when accessing the status.