Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inability to express a positive offset of less than an hour #13

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

With the current API Offset::of(0, 30) is interpreted as -00:30.

Solution

Use explicit ::plus and ::minus named constructors.

@Baptouuuu Baptouuuu added the bug label Nov 24, 2024
@Baptouuuu Baptouuuu self-assigned this Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (f260ba7) to head (12382d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #13   +/-   ##
==========================================
  Coverage      99.91%   99.91%           
- Complexity       694      695    +1     
==========================================
  Files             54       54           
  Lines           2246     2248    +2     
==========================================
+ Hits            2244     2246    +2     
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Baptouuuu Baptouuuu merged commit 04f9bbb into develop Nov 24, 2024
15 checks passed
@Baptouuuu Baptouuuu deleted the fix-offset-negative-zero branch November 24, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant