Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support #16

Merged
merged 7 commits into from
Jan 19, 2025
Merged

Add PHP 8.4 support #16

merged 7 commits into from
Jan 19, 2025

Conversation

Baptouuuu
Copy link
Member

@Baptouuuu Baptouuuu commented Jan 19, 2025

While running blackbox for the PHP 8.4 support it found a bug where mktime produced errors since the values below 101 for the year represent the dates between 1970 and 2069.

Hence the big diff on Day and Month.

@Baptouuuu Baptouuuu self-assigned this Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (30b5067) to head (503d0e5).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #16      +/-   ##
=============================================
- Coverage      99.91%   99.80%   -0.12%     
- Complexity       706      748      +42     
=============================================
  Files             56       56              
  Lines           2495     2530      +35     
=============================================
+ Hits            2493     2525      +32     
- Misses             2        5       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit 28182b8 into develop Jan 19, 2025
20 of 21 checks passed
@Baptouuuu Baptouuuu deleted the php84 branch January 19, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant