a lot of bugfixes - #414
Conversation
…doesn't crash without so idk
|
bruh ive found critical bug |
|
its all good |
how i done it will probably delay _game over call_ for 1 tick. but as i tested it i didnt notice any problems becouse of that
|
reverted run separator msg |
|
|
||
| local in_camera_ref | ||
|
|
||
| local appdata = os.getenv("APPDATA") |
There was a problem hiding this comment.
Consider saving files on local proxy directory since APPDATA works ONLY on windows and returns nil on macos and linux
There was a problem hiding this comment.
no it would return the appdata fine, since noiter is only windows so macos/linux is proton/wine
There was a problem hiding this comment.
oh, i did not account that, i forgot ye my bad
|
Sorry, you may have to rebase your changes since we've recently cleaned up our master branch. Also, are we planning to merge this? Seems to linger for awhile now. And we would be appreciated if the commits were clean up and describe what were changed in their appropriate scope since it seems to be really difficult to review. |
|
hi im kinda new to contributing so please tell me what exactly are my errors in commits descriptions (exept their absense) and ill be better in the future. i tried to name all my commits the way so their names shortly overview their content. |
4 participants
delete button functions as delete button, ctrl+ delete implemented, old features with saving chat when game is closed + its disablable, chat window is centered, russian or actually any symbols thats 2-3-4 bytes works properly now, chat color setting working wrong fixed and a few minor bug fixes.
no changing color&nickname in chat history yet sorry. will add it in next pull with some quality additions