Orchestration in VDMS with Kubernetes #261
Conversation
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 97.94% |
|
Target CPP Coverage: 64.1323% Target Python Coverage: 97.94% |
…into kubernetes_support
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
…into kubernetes_support
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
There was a problem hiding this comment.
Nothing was leaping out, but I do have some concerns at the level of complexity of the utilities we're bolting on, and think we might want to have a discussion at some point of teasing apart some of the pieces into more isolated libraries/calls (e.g. VCL, K8s support, etc).
That said, approved.
| { | ||
| echo "" | ||
| echo "Usage: $0 -m machinetype -i install -s setup_the_node -k k8s_setup -c clear_the_node -j local_kubeConfig" | ||
| echo "\t-m Input the machine type either 'remote' or 'master'" |
There was a problem hiding this comment.
Minor nit: we try to avoid using term "master" these days. "primary" is a good alternative.
| sudo docker tag remote-udf-1 localhost:5000/remote-udf-1 | ||
| sudo docker push localhost:5000/remote-udf-1 | ||
| } | ||
| remoteInstallFunction() |
There was a problem hiding this comment.
I dont think there's a lot we can do in the short term, but I'm concerned about the number of hard coded paths and URLs I'm seeing. This script may be difficult to maintain in the long term given our relatively limited development resources.
Closes #246