210 Integration of descriptor sets into neo4j based handler #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sets-into-neo4j-based-handler
…-sets-into-neo4j-based-handler
|
Target CPP Coverage: 64.1421% Target Python Coverage: 97.94% |
cwlacewe
requested changes
Mar 12, 2025
| @@ -62,7 +74,7 @@ void QueryHandlerNeo4j::init() { | |||
| char *pass = getenv("NEO4J_PASS"); | |||
|
|
|||
| uint_fast32_t flags = NEO4J_INSECURE; | |||
| int nr_conns = 16; | |||
| int nr_conns = 32; //TODO update to be configurable | |||
There was a problem hiding this comment.
When can we make this configurable?
There was a problem hiding this comment.
Need the right phase of the moon.
I think I have a ticket open for it, Ill check there, if we dont, Ill create one. At the moment 32 is enough for most use-cases, and when we exceed it, its not as big a problem as with PMGD as we dont have the same gnarly timeouts, the VDMS logic just waits until one pops up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to do the following with Neo4J based metadat storage
It currently does not support graph traversal for adding and retrieval of descriptors, but otherwise has feature parity with the existing PMGD based descriptor set support.
Note that I will be continuing cleanup and test development while this PR is open, as this PR is relatively complex and want to be able to parallelize changes as we go along.