Skip to content

Addresses gh-1360 with documentation #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

Addresses gh-1360 with documentation #1653

merged 2 commits into from
Apr 23, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Document race condition in put when indices array contain duplicated. Provide an example of resolving race condition for 1-d x, indices, and vals.

This PR supersedes gh-1384, since support for unique_only can not be efficiently support for higher rank arrays with axes specified.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Addresses gh-1360 with documentation
124458f 
Document race condition in put when indices array contain duplicated.
Provide an example of resolving race condition for 1-d ``x``, ``indices``,
and ``vals``.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Apr 23, 2024 •
edited
Loading

Coverage Status

coverage: 88.21%. remained the same
when pulling 18df92a on document-race-condition-in-put
into 7757857 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_302 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@oleksandr-pavlyk
Removed obsolete notice in description of indices
18df92a 
Also, improved wording in the added note.
ndgrigorian
ndgrigorian approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, good to have this example!

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_309 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@oleksandr-pavlyk oleksandr-pavlyk merged commit 379b939 into master Apr 23, 2024
55 of 58 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the document-race-condition-in-put branch April 23, 2024 23:26
This was referenced Apr 23, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian