Update Level Zero loader detection for newer compiler builds #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
|
@sommerlukas The only thing left is to make sure it works on Windows with nightly compiler |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_59 ran successfully. |
sommerlukas
reviewed
Mar 18, 2025
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_68 ran successfully. |
sommerlukas
approved these changes
Mar 19, 2025
antonwolfy
previously approved these changes
Mar 21, 2025
ndgrigorian
force-pushed
the
update-level-zero-loader-detection
branch
from
d8bb37f to
42db46d
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_75 ran successfully. |
antonwolfy
approved these changes
Mar 31, 2025
SYCL nightly and future builds now link libur_adapter_level_zero to the level zero loader statically, so detecting through readelf is no longer possible For this case, we instead set the default Level Zero Loader filename to be 'libze_loader.so.1,' which is likely to not change See: intel/llvm#17104
Allows users to set Level Zero loader filename
ndgrigorian
force-pushed
the
update-level-zero-loader-detection
branch
from
42db46d to
3117a94
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_78 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of intel/llvm#17104
libur_adapter_level_zero.sois statically linked to the Level Zero loader, meaning that the shared object can no longer be read for the loader filenameTo resolve this, a default filename is now set in CMake, as it is unlikely to change. For backwards compatibility, it is only set to the default value if the object file is read and the loader is not found through the original approach.
Resolves #2022