Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Fix Windows CI with 2025.1.0 compiler #2034

Merged
merged 2 commits into from
Mar 31, 2025
Merged

[MAINT] Fix Windows CI with 2025.1.0 compiler #2034

merged 2 commits into from
Mar 31, 2025

Conversation

ndgrigorian
Copy link
Collaborator

After the release of 2025.1.0 compiler, Windows CI broke when building with 2025.0.4 and testing on 2025.1.0

This PR works around the problem by installing the 2025.1.0 compiler in the environment when building

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the fix-windows-ci-failure-2025.1 branch 2 times, most recently from 68097b8 to f5425b2 Compare March 28, 2025 22:35
@ndgrigorian
Fix failure of Windows CI when dpctl is built with 2025.0.4 and run w…
7ad8972 
…ith 2025.1.0

Build with 2025.1.0 as a work-around
@ndgrigorian ndgrigorian force-pushed the fix-windows-ci-failure-2025.1 branch from f5425b2 to 7ad8972 Compare March 28, 2025 22:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Mar 28, 2025 •
edited
Loading

Coverage Status

coverage: 86.752%. remained the same
when pulling 745ec43 on fix-windows-ci-failure-2025.1
into c5d18f4 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

1 similar comment
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_74 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

@ndgrigorian ndgrigorian requested a review from antonwolfy March 30, 2025 16:14
@ndgrigorian ndgrigorian merged commit 63f5129 into master Mar 31, 2025
75 checks passed
@ndgrigorian ndgrigorian deleted the fix-windows-ci-failure-2025.1 branch March 31, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @antonwolfy