Skip to content

fix an issue for real inputs of irfft #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 9, 2025

resolves #176

@vtavana vtavana self-assigned this May 9, 2025
@vtavana vtavana force-pushed the fix-dtype-error branch 4 times, most recently from bcfbb46 to 0231689 Compare May 9, 2025 13:29
@vtavana vtavana force-pushed the fix-dtype-error branch from 0231689 to 5f71898 Compare May 9, 2025 13:36
@vtavana vtavana marked this pull request as ready for review May 9, 2025 14:21
@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 14:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue related to the handling of real inputs for the irfft function and improves consistency across tests and workflows. Key changes include:

  • Updating test conditions for various scipy versions and adding new tests for irfft data type consistency.
  • Modifying implementations in the numpy FFT interface functions to correct conjugation handling.
  • Adjusting GitHub workflow commands to update package installation steps.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mkl_fft/tests/third_party/scipy/test_basic.py Simplified skip calls and updated version range comments
mkl_fft/tests/test_fft1d.py Added new test (test_irfft_dtype) to validate irfft output dtypes
mkl_fft/interfaces/_numpy_fft.py Adjusted conjugation in hfft and renamed output variable in ihfft
CHANGELOG.md Updated changelog entries for fixed input/output dtype inconsistency
.github/workflows/conda-package.yml Modified conda commands for environment creation and package install
.github/workflows/conda-package-cf.yml Similar modifications to conda install commands in continuous flow
Files not reviewed (1)
  • mkl_fft/_pydfti.pyx: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

irfft returns float64 for an input with dtype of float32
1 participant