Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality improvement #173

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

marcialouis
Copy link

Description

Add a comprehensive description of proposed changes

List associated issue number(s) if exist(s): #6 (for example)

Documentation PR (if needed): #1340 (for example)


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

ashageor and others added 6 commits March 5, 2025 16:31
Updating code from the main repo
… and Unresolved comment '# TODO: add float values'. lines of code = 1
Fixes in Unresolved comment '# TODO: remove placeholding zeroed y' and Fixes in Unresolved comment '# TODO: add float values'.
- Updated  to include additional information (, , and ) in the benchmark results.
- Ensured that the  dictionary is updated with the new fields and metrics.
- Modified  to handle and process the new data descriptors in the benchmark results.

These changes enhance the benchmark results by providing more detailed information about the dataset and its characteristics
Changes for datetime representation  Unresolved comment '# TODO: replace unix time in ms with datetime'.
@napetrov napetrov assigned icfaust and unassigned icfaust Mar 24, 2025
@napetrov napetrov requested a review from icfaust March 24, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants