Skip to content

remove jit silu and jit gelu#392

Closed
sallyjunjun wants to merge 1 commit intodevelopfrom
fix-jit-silu
Closed

remove jit silu and jit gelu#392
sallyjunjun wants to merge 1 commit intodevelopfrom
fix-jit-silu

Conversation

@sallyjunjun
Copy link
Collaborator

@sallyjunjun sallyjunjun commented Dec 18, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When testing 256k llm, there occurs some error in jit silu. Therefore, we remove Silu = torch.jit.script(Silu) here. The performance of training internlm 7B with and without jit silu is as follows:
image

Removing jit silu has almost no impact on training performance.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sunpengsdu sunpengsdu closed this Dec 28, 2024
@sallyjunjun sallyjunjun deleted the fix-jit-silu branch March 20, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants