Skip to content

【CI】add qwen3.5 cases#1593

Open
kkscilife wants to merge 11 commits intomainfrom
ci/cases
Open

【CI】add qwen3.5 cases#1593
kkscilife wants to merge 11 commits intomainfrom
ci/cases

Conversation

@kkscilife
Copy link
Collaborator

@kkscilife kkscilife commented Mar 18, 2026

  1. add qwen3.5 cases
  2. fix gptoss config
  3. TODO: update threshold to 1e-6

@kkscilife kkscilife requested a review from HAOCHENYE March 20, 2026 07:42
@kkscilife
Copy link
Collaborator Author

@claude review

@claude
Copy link

claude bot commented Mar 20, 2026

Claude: ## Summary
Adds two new CI test cases (qwen3-sft-cache, qwen3-5-sft-vl-moe), fixes gptoss config to use OpenaiTokenizeFunctionConfig, and adds image_pull_policy="Always" to cluster runner.

Issues

Warning

  • autotest/config/qwen3_sft_cache.py:47 — Uses deprecated dataset_cfg parameter on TrainerConfig. Should use DataloaderConfig(dataset_config_list=...) instead (as done correctly in qwen3_5_30B_sft_vl.py).
  • autotest/config.yaml:320-321grad_norm and loss/reduced_llm_loss thresholds for qwen3-5-sft-vl-moe are set to 5, effectively disabling validation. PR description notes "TODO: update threshold to 1e-6" — should this be resolved before merge?
  • autotest/cluster/clusterx.py:53image_pull_policy="Always" is hardcoded for all jobs. Consider making it configurable via resource config.

Verdict

COMMENT — The core changes look correct. The deprecated API usage and loose thresholds should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant