Conversation
Cmdv
force-pushed
the
1678-epoch_stake-missing-entries
branch
2 times, most recently
from
4775489 to
9644c31
Compare
Cmdv
force-pushed
the
1678-epoch_stake-missing-entries
branch
from
9644c31 to
13838d6
Compare
Cmdv
force-pushed
the
1678-epoch_stake-missing-entries
branch
from
6f545af to
0242576
Compare
kderme
left a comment
kderme
left a comment
There was a problem hiding this comment.
This looks good. I'll make some modifications for the isMigration case and we can merge.
| assertEpochStake dbSync 5 | ||
| blks <- fillUntilNextEpoch interpreter mockServer | ||
| assertBlockNoBackoff dbSync (fromIntegral $ length blks) | ||
| -- There are 10 delegations in genesis |
There was a problem hiding this comment.
Is this comment correct or is the old comment wrong about genesi?
There was a problem hiding this comment.
it can be removed. I think in the previous implementation, by the time the assertEpochStake was called the epoch 2 wouldn't have been inserted. This is why I changed the tests to check each epoch 1 + 2 separately
What modification does it need? I'm happy to make the changes or discuss |
|
@kderme what steps do we need to take to get this in? I know you were doing something "I'm assigning the rest to myself for the migration fix." But Right now it would need rework due to the Hasql conversion changing lots of things. |
|
I'll take a look. This may end up being rewritten with the parallel stuf |
|
Superseded by #2044 |
2 participants
Description
This PR fixes #1678
Currently trying to log out the slice function as it's not behaving correctly
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.