Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mkAddr and mkCred interface #4879

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Improve mkAddr and mkCred interface #4879

merged 1 commit into from
Feb 7, 2025

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 6, 2025

Description

There are a bunch of places throughout the test suite that create addresses and credentials. This change unifies construction into a single abstract interface.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from a team as a code owner February 6, 2025 06:42
@lehins lehins force-pushed the lehins/improve-mkAddr branch 2 times, most recently from 1254764 to c0f530c Compare February 6, 2025 06:48
@lehins lehins requested a review from Soupstraw February 6, 2025 06:49
@lehins lehins force-pushed the lehins/improve-mkAddr branch from c0f530c to 7fefed0 Compare February 6, 2025 06:51
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins force-pushed the lehins/improve-mkAddr branch 3 times, most recently from 9f9b4f9 to f7cb6bf Compare February 7, 2025 00:51
@lehins lehins enabled auto-merge February 7, 2025 00:52
@lehins lehins force-pushed the lehins/improve-mkAddr branch from f7cb6bf to 9900306 Compare February 7, 2025 01:34
@lehins lehins force-pushed the lehins/improve-mkAddr branch from 9900306 to 4df915b Compare February 7, 2025 04:53
@lehins lehins merged commit 3fe73a2 into master Feb 7, 2025
153 of 158 checks passed
@lehins lehins deleted the lehins/improve-mkAddr branch February 7, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants