Skip to content

Comments

bench | ssd cluster#6236

Merged
fmaste merged 10 commits intomasterfrom
bench/ssd-cluster
Jun 24, 2025
Merged

bench | ssd cluster#6236
fmaste merged 10 commits intomasterfrom
bench/ssd-cluster

Conversation

@fmaste
Copy link
Contributor

@fmaste fmaste commented May 29, 2025

Description

  • Make profiles' "cluster" property null when not used (it had an "empty" value).
  • Move the "ssd_directory" profile property from "cluster" to "node", it's a node config that may or may not be related to what's defined in "cluster".
  • Allow defining Nomad volumes only for producer nodes (nodes that are not the explorer).
  • Switch producers instance types from "c5.2xlarge" to "c5d.2xlarge" for the perf cluster.
  • Add "value" and "plutus" LMDB profiles with its Nomad volume for the perf cluster.
  • New "new plutusv3-volt-nomadperf" profile.
  • Changes that support creating Nomad clusters for testing.
  • Checked with dyff between that final changes to "all-profiles-coay.json" make sense!
  • Update cardano timeline and openssh, other minor cleanups and fixes.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@fmaste fmaste force-pushed the bench/ssd-cluster branch 5 times, most recently from 1711d98 to 47929ce Compare June 2, 2025 21:41
@fmaste fmaste force-pushed the bench/ssd-cluster branch from c7a27b8 to 38e18fb Compare June 11, 2025 13:26
@mgmeier mgmeier force-pushed the bench/ssd-cluster branch from 38e18fb to f781e52 Compare June 23, 2025 07:41
@fmaste fmaste changed the title Bench/ssd cluster bench | ssd cluster Jun 23, 2025
@fmaste fmaste marked this pull request as ready for review June 23, 2025 14:55
@fmaste fmaste requested a review from a team June 23, 2025 14:55
@fmaste fmaste requested review from a team as code owners June 23, 2025 14:55
@mgmeier mgmeier force-pushed the bench/ssd-cluster branch 2 times, most recently from 45dc7b9 to 30d339e Compare June 24, 2025 10:01
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmaste fmaste enabled auto-merge June 24, 2025 13:07
@fmaste fmaste force-pushed the bench/ssd-cluster branch from 30d339e to 836a081 Compare June 24, 2025 13:16
@fmaste fmaste added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@fmaste fmaste added this pull request to the merge queue Jun 24, 2025
Merged via the queue into master with commit 781646a Jun 24, 2025
26 checks passed
@fmaste fmaste deleted the bench/ssd-cluster branch June 24, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants