Re-evaluation of mainnet scripts to verify backward compatibility. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Unisay
force-pushed
the
yura/verifyEd25519Signature_V2
branch
from
f0b5700 to
a0eb3e7
Compare
kwxm
reviewed
Feb 5, 2025
There was a problem hiding this comment.
I've had a look at this and didn't understand all of the details, but nothing jumped out as being obviously crazy. Do you actually want to merge all of this though? There are quite a lot of changes that look as if they should be merged, but the SRP that changes the evaluator is presumably something you'd not want to merge permanently: I suppose that if we want to re-use this to do something else later then we'd need a different SRP.
Unisay
force-pushed
the
yura/verifyEd25519Signature_V2
branch
2 times, most recently
from
67aa404 to
3aa5132
Compare
Unisay
force-pushed
the
yura/verifyEd25519Signature_V2
branch
from
3aa5132 to
5e19aed
Compare
Unisay
changed the title
|
I have removed the SRP in order to merge the Evaluation job itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plutus-coreis used via the S-R-P with this change.