Skip to content

Added support for Alerts Headers #44 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

mitchelsellers
Copy link
Contributor

@mitchelsellers mitchelsellers commented Feb 17, 2025

Summary by CodeRabbit

  • New Features
    • Introduced an enhanced alert that supports an optional header, adding clarity and emphasis to important notifications.
    • Updated sample displays to showcase this new alert style, providing users with a clearer presentation of alert messages.

@mitchelsellers mitchelsellers merged commit bc204c1 into develop Feb 17, 2025
1 check passed
Copy link

coderabbitai bot commented Feb 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the HTML and TagHelper logic for alert components. In the view file, a redundant row labeled "Warning Dismissible" was removed and re-added, and a new row for "Alert With Header" was introduced. The TagHelper now includes a new property, HeadingText, and modifies its processing to conditionally render an <h4> element when a header is provided. Additionally, minor refactoring was applied, such as explicit variable type declarations.

Changes

File(s) Change Summary
src/AspNetCore.Utilities.Bootstrap5TagHelpers.Sample/Views/Home/Index.cshtml Removed and re-added the "Warning Dismissible" row; added a new "Alert With Header" row featuring an alert component with a header (using a new attribute).
src/AspNetCore.Utilities.Bootstrap5TagHelpers/AlertTagHelper.cs Added new property HeadingText; updated ProcessAsync to check for HeadingText and insert an <h4> element with class alert-heading if provided; used explicit type declaration for the existing variable.

Sequence Diagram(s)

sequenceDiagram
    participant V as View (CSHTML)
    participant A as AlertTagHelper
    participant O as Output Generator

    V->>A: Render alert tag with optional HeadingText
    A->>A: Check if HeadingText is provided
    alt HeadingText provided
        A->>O: Insert <h4 class="alert-heading">HeadingText</h4>
    else
        A->>O: Proceed without header
    end
    A->>A: Check if alert is dismissible
    alt Dismissible
        A->>O: Insert dismiss button
    else
        A->>O: Omit dismiss button
    end
    A->>V: Return complete alert HTML
Loading

Poem

I'm a happy rabbit in a code-filled glade,
Hoping through new changes that neatly cascade.
A header appears with a gentle hop,
Alerts and buttons now perfectly crop.
With whiskers twitching in delight,
I celebrate this update day and night!
🐇💻


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94df143 and 9652175.

📒 Files selected for processing (2)
  • src/AspNetCore.Utilities.Bootstrap5TagHelpers.Sample/Views/Home/Index.cshtml (1 hunks)
  • src/AspNetCore.Utilities.Bootstrap5TagHelpers/AlertTagHelper.cs (3 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mitchelsellers mitchelsellers deleted the feature/form-check-support branch February 17, 2025 20:00
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.58% (target: -1.00%) 42.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (223e59a) 489 399 81.60%
Head commit (9652175) 495 (+6) 401 (+2) 81.01% (-0.58%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#47) 7 3 42.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Additional Alert Helpers
1 participant