Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: irys token prices data added to the config #236

Merged
merged 44 commits into from
Feb 27, 2025
Merged

feat: irys token prices data added to the config #236

merged 44 commits into from
Feb 27, 2025

Conversation

roberts-pumpurs
Copy link
Contributor

@roberts-pumpurs roberts-pumpurs commented Feb 20, 2025 •
edited
Loading

Describe the changes

  • adds Irys token price-related data to the root consensus Config
  • major refactoring of how the config is accessed by the rest of the system

Related Issue(s)
#180

Checklist

  • Tests have been added/updated for the changes.
  • Documentation has been updated for the changes (if applicable).
  • The code follows Rust's style guidelines.

@roberts-pumpurs roberts-pumpurs self-assigned this Feb 20, 2025
@roberts-pumpurs roberts-pumpurs changed the title Rob/prices in config feat: irys token prices data added to the config Feb 20, 2025
@roberts-pumpurs roberts-pumpurs requested review from DanMacDonald and JesseTheRobot and removed request for DanMacDonald February 24, 2025 18:12
roberts-pumpurs
roberts-pumpurs commented Feb 24, 2025
View reviewed changes
@roberts-pumpurs roberts-pumpurs marked this pull request as ready for review February 24, 2025 18:22
@roberts-pumpurs
Copy link
Contributor Author

I'll fix the fmt & check fails first thing tomorrow

JesseTheRobot
JesseTheRobot reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback on the current state, mostly cosmetic, core looks solid

@roberts-pumpurs roberts-pumpurs mentioned this pull request Feb 25, 2025
Open
@roberts-pumpurs roberts-pumpurs mentioned this pull request Feb 25, 2025
Open
@JesseTheRobot JesseTheRobot mentioned this pull request Feb 11, 2025
Open
43 tasks
JesseTheRobot
JesseTheRobot approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a couple non-blocking mostly cosmetic tweaks

@roberts-pumpurs roberts-pumpurs mentioned this pull request Feb 27, 2025
Open
@roberts-pumpurs roberts-pumpurs merged commit 1077e3e into master Feb 27, 2025
9 checks passed
@roberts-pumpurs roberts-pumpurs deleted the rob/prices-in-config branch February 27, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseTheRobot JesseTheRobot JesseTheRobot approved these changes

@DanMacDonald DanMacDonald Awaiting requested review from DanMacDonald

Assignees

@roberts-pumpurs roberts-pumpurs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roberts-pumpurs @JesseTheRobot @ernius