Add Features...and some bugfixes #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some refactorings, added parameters for grid dimensions in order to avoid sparse and repeated use of dimension number in code. Fixed bug preventing showing of s2 and l2 pieces, extended indexcolor converter for supporting these 2 pieces, Renamed i"type" property in Piece class to IndexColor
Fixed end game detection, added parameters on Piece constructor to inizialize position
Decoupled Game class from Avalonia: use an enum to express grid fill changed color converter by using the aforementioned enum changed indexColor (previous was "type" property yo FillType fixed some bugs in for cycles limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ivan,
I saw your project some weeks ago when i was doing some experiments with Avalonia in Linux, and i found your tetris implementation inspiring so I decided to try to play with your code...and so i went to having fun and i tried to add some fancy ideas or fixing some bugs. I noted too late that you had added the "Show next piece" feature, when i already played to add that, thus not yet commited at time, but please take a look at my implementation.
So, below i'm summarizing the changes in this PR:
I colud agree that the changes in the code could be somewhat "invasive" but take they as your discretion.
The grid on\off could be subjective aesthetic. The next piece as no grid at all.
The blinking of the lines that are about to be removed is a thing that i saw on some old Tetris, so i decided could be nice to have. I know it could be implement differently (by using Storyboard?), but i think the current is straightforward.
Moreover, the game area dimensions are easily modifiable with two parameters, varing the difficult of the game.
Looking forward to your reply,
Best regards.
DM
P.s
This is my first PR, so let me know if you need other details or how can i do more effectively.