Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
デフォルト引数でend_dtをnowを設定している部分をNoneに変更し、関数内でNoneであった場合にnowを設定する
WHY
Effective Pythonなどで指摘されているように、デフォルトの引数はモジュールが初期化されたときに一度だけ呼び出される。
このため、数日間実行されるプログラムでデータを取得するプログラムを実行しても、最新の日付を取得できない。
これはユーザの意図と異なりうるので、関数の呼び出し時の時刻をend_dtに設定できるように変更した。
最小限の再現コード