Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MET v12.0.0 and METplus v6.0.0 #509

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Add MET v12.0.0 and METplus v6.0.0 #509

merged 7 commits into from
Feb 20, 2025

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 29, 2025 •
edited
Loading

Description

This PR adds [email protected] and [email protected]. Credits to @rickgrubin-noaa (cherry-picked add met@12 and metplus@6) for the original set of changes.

These new versions were tested by a NRL colleaguge using a spack-stack installation based on PR JCSDA/spack-stack#1481 on Nautilus.

@climbfuji climbfuji mentioned this pull request Jan 29, 2025
Merged
6 tasks
@climbfuji climbfuji self-assigned this Jan 29, 2025
@rickgrubin-noaa
Copy link
Collaborator

Should configs/templates/gsi-addon-dev/spack.yaml also be updated?

  packages:
      met:
         require:: '@9.1.3 +python +grib2'
      metplus:
         require:: '@3.1.1 ^[email protected]'

@climbfuji
Copy link
Collaborator Author

Should configs/templates/gsi-addon-dev/spack.yaml also be updated?

  packages:
      met:
         require:: '@9.1.3 +python +grib2'
      metplus:
         require:: '@3.1.1 ^[email protected]'

@DavidHuber-NOAA ?

@DavidHuber-NOAA
Copy link
Collaborator

@rickgrubin-noaa No, the gsi-addon needs to stay at 3.1.1/9.1.3 until the global workflow updates to a newer verification system.

A slightly longer answer: the METplus API completely changed between version 3 and version 4, so our existing verification package would need a complete overhaul. There is a new verification system in operational GFS v16 called EVS, but it is not yet supported on any of the research platforms nor by the develop version of the global workflow. I am not sure when this will be brought into the global workflow, but it probably needs to be soon.

@climbfuji climbfuji marked this pull request as ready for review February 19, 2025 20:39
AlexanderRichert-NOAA
AlexanderRichert-NOAA reviewed Feb 20, 2025
View reviewed changes
var/spack/repos/builtin/packages/metplus/package.py Outdated
Comment on lines 38 to 49
depends_on("[email protected]:", when="@6.0.0", type=("run"))
depends_on("met@12:+python", when="@6.0.0", type=("run"))
depends_on("met+python", type=("run"))
# https://metplus.readthedocs.io/en/main_v6.0/Users_Guide/installation.html
depends_on("[email protected]:", when="@6.0.0")
depends_on("netcdf-c")
depends_on("[email protected]:", when="@6.0.0", type=("run"))
depends_on("py-python-dateutil", type=("run"))

depends_on("[email protected]:", when="@6.0.0 +makeplots", type=("run"))
depends_on("py-cartopy", when="+makeplots", type=("run"))
depends_on("[email protected]", when="@6.0.0 +cycloneplotter", type=("run"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not '@6:' for all of these, since I'm assuming it won't just be for the one release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, let me change that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@climbfuji climbfuji merged commit 0978cb9 into JCSDA:spack-stack-dev Feb 20, 2025
15 checks passed
@climbfuji climbfuji mentioned this pull request Feb 20, 2025
Open
@climbfuji
Copy link
Collaborator Author

Corresponding spack develop PR: spack#49120

@climbfuji climbfuji deleted the feature/met12_metplus6 branch February 20, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RatkoVasic-NOAA RatkoVasic-NOAA RatkoVasic-NOAA approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

@rickgrubin rickgrubin Awaiting requested review from rickgrubin

Assignees

@climbfuji climbfuji

Labels
None yet
Projects
spack-stack-2.0.0 (2025 Q1-Q2)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@climbfuji @rickgrubin-noaa @DavidHuber-NOAA @RatkoVasic-NOAA @AlexanderRichert-NOAA