Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test serialization of nullable types Int64 and string #425

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Test serialization of nullable types Int64 and string #425

wants to merge 1 commit into from

Conversation

mlondschien
Copy link
Contributor

I'd like to add pd.NA here but the values are used for partitioning.

@mlondschien
Copy link
Contributor Author

Tests are passing. Not sure if this is good or bad. @fjetter would you prefer to merge this as is and fix #410 in a separate PR or extend here?

@fjetter
Copy link
Collaborator

fjetter commented Mar 11, 2021

I'm not yet sure how #410 should be fixed but I don't see a reason why this should not be included

@mlondschien mlondschien mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlondschien @fjetter