Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿšง ํŒŒ์ผ ์—…๋กœ๋“œ API path ํ†ต์ผ ๋ฐ ์ธ์ฆ ๋กœ์ง ์ถ”๊ฐ€ #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

๐Ÿšง ํŒŒ์ผ ์—…๋กœ๋“œ API path ํ†ต์ผ ๋ฐ ์ธ์ฆ ๋กœ์ง ์ถ”๊ฐ€ #50

wants to merge 1 commit into from

Conversation

Hanjaemo
Copy link
Member

#๏ธโƒฃ์—ฐ๊ด€๋œ ์ด์Šˆ

close #40

๐Ÿ“์ž‘์—… ๋‚ด์šฉ

  • ํŒŒ์ผ ์—…๋กœ๋“œ API path ํ†ต์ผ

ํŒŒ์ผ ์—…๋กœ๋“œ API ์š”์ฒญ body์— ๊ธฐ๋ณธ์ ์œผ๋กœ ๋ฐฐ์—ด์„ ์ „๋‹ฌํ•˜๋Š” ๋ฐฉ์‹์œผ๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ…ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

image

@Hanjaemo Hanjaemo added โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ‘จ๐Ÿปโ€๐Ÿ’ปbackend ๋ฐฑ์—”๋“œ ์ž‘์—… ๐Ÿช„refactor ๋ฆฌํŒฉํ† ๋ง labels Feb 18, 2025
@Hanjaemo Hanjaemo self-assigned this Feb 18, 2025
@Hanjaemo Hanjaemo linked an issue Feb 18, 2025 that may be closed by this pull request
[FEAT] pre-signed url ์ƒ์„ฑ API path ํ†ต์ผ ๋ฐ ์ธ์ฆ ์–ด๋…ธํ…Œ์ด์…˜ ์ถ”๊ฐ€ #40
Open
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Test Results

27 testsโ€‚โ€ƒโ€ƒ27 โœ…โ€ƒโ€ƒ3s โฑ๏ธ
11 suitesโ€ƒโ€ƒโ€‡0 ๐Ÿ’ค
11 filesโ€„โ€‚โ€ƒโ€ƒโ€‡0 โŒ

Results for commit cc15d6e.

โ™ป๏ธ This comment has been updated with latest results.

YeaChan05
YeaChan05 reviewed Feb 18, 2025
View reviewed changes
src/test/java/org/ject/support/external/s3/S3ServiceTest.java
@@ -76,17 +90,25 @@ private String removePrefix(String keyName) {

static class TestParameter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฌ์ฒด์ ์œผ๋กœ ์–ด๋–ค ์—ญํ• ์„ ํ•˜๋Š” ๊ฐ์ฒด์ธ๊ฐ€์š”? ์š”์ฒญ ๋งค๊ฐœ๋ณ€์ˆ˜์— ๋Œ€ํ•œ mocking์ธ๊ฐ€์š”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YeaChan05 YeaChan05 YeaChan05 left review comments

@gywns0417 gywns0417 gywns0417 approved these changes

Assignees

@Hanjaemo Hanjaemo

Labels
๐Ÿ‘จ๐Ÿปโ€๐Ÿ’ปbackend ๋ฐฑ์—”๋“œ ์ž‘์—… โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿช„refactor ๋ฆฌํŒฉํ† ๋ง
Projects
JECT Official WebSite
Status: No status
Milestone
No milestone
3 participants
@Hanjaemo @gywns0417 @YeaChan05