Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda_QCD declarations to match JETSCAPE 3.6.1 #9

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Lambda_QCD declarations to match JETSCAPE 3.6.1 #9

merged 1 commit into from
Feb 19, 2024

Conversation

latessa
Copy link
Collaborator

@latessa latessa commented Feb 17, 2024

adds the changes made to the Lambda_QCD declarations in JETSCAPE 3.6.1 to additional classes specific to X-SCAPE.

@latessa
Lambda_QCD declarations to match JETSCAPE 3.6.1
14cb661 
matching the Lambda_QCD declarations as changed in JETSCAPE 3.6.1
in classes specific to X-SCAPE.
@latessa latessa self-assigned this Feb 17, 2024
@latessa latessa requested a review from ismasou February 17, 2024 17:44
@latessa
Copy link
Collaborator Author

latessa commented Feb 17, 2024 •
edited
Loading

@Hendrik1704 @ismasou, JETSCAPE 3.6.1-RC moved the Lambda_QCD declaration out of the JetScapeConstants header, but some classes specific to X-SCAPE still relied on the original declaration. This PR applies the declaration changes from JETSCAPE-3.6.1-RC to additional X-SCAPE classes.

@latessa latessa requested a review from Hendrik1704 February 17, 2024 17:44
@latessa latessa removed their assignment Feb 17, 2024
Hendrik1704
Hendrik1704 approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@Hendrik1704 Hendrik1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This matches all the changes to the lambdaQCD parameter, which are in the upcoming JESTCAPE-3.6.1.

ismasou
ismasou approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ismasou ismasou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, it looks good to me too.

@latessa latessa merged commit 7ab53e9 into XSCAPE-1.1.1-RC Feb 19, 2024
7 checks passed
@latessa latessa added this to the X-SCAPE 1.1.1 Release milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismasou ismasou ismasou approved these changes

@Hendrik1704 Hendrik1704 Hendrik1704 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
X-SCAPE 1.1.1 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@latessa @ismasou @Hendrik1704