Fix: station rating tooltip outline #799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The current station rating tooltip uses four
GfxDrawLine
, which causes problems with larger interface sizes.Description
Reference:
https://github.com/citymania-org/cmclient/blob/02d6792570e1ff228d15ba968af9f36e04d23a68/src/citymania/cm_tooltips.cpp#L141-L144
Use this piece of code from cmclient.
There isn't a default gray window fill, so instead of using single rect to overlap the other rect (vanilla tooltips), use four rects.
Limitations
None that I can think of.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.