Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: station rating tooltip outline #799

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

WenSimEHRP
Copy link
Contributor

Motivation / Problem

The current station rating tooltip uses four GfxDrawLine, which causes problems with larger interface sizes.

1x 4x
image image

Description

Reference:

https://github.com/citymania-org/cmclient/blob/02d6792570e1ff228d15ba968af9f36e04d23a68/src/citymania/cm_tooltips.cpp#L141-L144

Use this piece of code from cmclient.

There isn't a default gray window fill, so instead of using single rect to overlap the other rect (vanilla tooltips), use four rects.

1x 2x 4x
image image image

Limitations

None that I can think of.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@WenSimEHRP WenSimEHRP force-pushed the station-rating-tooltip branch from a98fd57 to c328a6f Compare January 2, 2025 07:30
@JGRennison JGRennison merged commit d31cb1e into JGRennison:jgrpp Jan 2, 2025
10 checks passed
@JGRennison
Copy link
Owner

Thanks

@WenSimEHRP WenSimEHRP deleted the station-rating-tooltip branch January 2, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants