[BE/FEAT] 민감 정보 동의 여부 받기 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LJH098
reviewed
Jan 9, 2025
Comment on lines
45
to
50
| @Column( | ||
| name = ENTITY_PREFIX + "_IS_SENSITIVE_DATA_AGREE", | ||
| columnDefinition = "tinyint", | ||
| nullable = false) | ||
| private Boolean isSensitiveDataAgree = true; | ||
|
|
There was a problem hiding this comment.
private Boolean isSensitiveDataAgree = true;
이렇게 한게 기본값으로 true가 되게 하려고 한건가요?
There was a problem hiding this comment.
애초에 기본값을 true 설정할 필요가 없었네요. 저 true 제거해야할 거 같네요.
@Builder.Default를 추가하고 private Boolean isSensitiveDataAgree = true; 이렇게 해놔야 Builder를 통해 객체 생성 시 자동으로 true로 설정되는 걸로 알고있습니다.
There was a problem hiding this comment.
@hwangdaesun
그러면 AgreementEntity의 나머지 필드에 = true 되있는것도 @Builder.Default가 없으니 무용지물 아닌가요?? 지워도 될 것 같은데
|
|
LJH098
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌관련 이슈
#618
🔑 주요 변경사항