bug: 지원자의 프로토콜이 붙지 않은 포트폴리오 링크에 대한 버그 수정 (#224)

JNU-econovation · Sep 21, 2024 · a1da0e2 · a1da0e2
2 parents 181babc + 5a9b6ff
commit a1da0e2
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 6 deletions.
diff --git a/frontend/components/applicant/applicantNode/Portfolio.tsx b/frontend/components/applicant/applicantNode/Portfolio.tsx
@@ -1,6 +1,7 @@
 import Txt from "@/components/common/Txt.component";
 import { ApplicantReq } from "@/src/apis/applicant";
 import { applicantDataFinder } from "@/src/functions/finder";
+import { changeIntactUrl } from "@/src/utils/applicant";
 import Link from "next/link";
 
 interface PortfolioProps {
@@ -12,15 +13,15 @@ const Portfolio = ({ data }: PortfolioProps) => {
 
   const portfolio = applicantDataFinder(data, "portfolio")
     .split(regex)
-    .map((url: string) => url.trim());
+    .map((url: string) => changeIntactUrl(url.trim()));
 
   const file = applicantDataFinder(data, "fileUrl")
     .split(regex)
-    .map((url: string) => url.trim());
+    .map((url: string) => changeIntactUrl(url.trim()));
 
   const fileUrlForPlanner = applicantDataFinder(data, "fileUrlforPlanner")
     .split(regex)
-    .map((url: string) => url.trim());
+    .map((url: string) => changeIntactUrl(url.trim()));
 
   return (
     <>
@@ -30,7 +31,12 @@ const Portfolio = ({ data }: PortfolioProps) => {
           <Txt typography="h6">링크</Txt>
           {portfolio.map((url: string, index: number) => {
             return (
-              <Link href={url} target="_blank" key={index}>
+              <Link
+                href={url}
+                target="_blank"
+                rel="noopener noreferrer"
+                key={index}
+              >
                 <Txt className="break-all">{url}</Txt>
               </Link>
             );
@@ -40,7 +46,12 @@ const Portfolio = ({ data }: PortfolioProps) => {
           <Txt typography="h6">파일</Txt>
           {file.map((url: string, index: number) => {
             return (
-              <Link href={url} target="_blank" key={index}>
+              <Link
+                href={url}
+                target="_blank"
+                rel="noopener noreferrer"
+                key={index}
+              >
                 <Txt className="break-all">{url}</Txt>
               </Link>
             );
@@ -51,7 +62,12 @@ const Portfolio = ({ data }: PortfolioProps) => {
             <Txt typography="h6">이번 학기 프로젝트 기획서</Txt>
             {fileUrlForPlanner.map((url: string, index: number) => {
               return (
-                <Link href={url} target="_blank" key={index}>
+                <Link
+                  href={url}
+                  target="_blank"
+                  rel="noopener noreferrer"
+                  key={index}
+                >
                   <Txt className="break-all">{url}</Txt>
                 </Link>
               );

diff --git a/frontend/src/utils/applicant/index.ts b/frontend/src/utils/applicant/index.ts
@@ -7,3 +7,13 @@ export const findApplicantState = (
   return cardsData.find((card) => card.applicantId === applicantId)?.state
     .passState;
 };
+
+export const changeIntactUrl = (url: string) => {
+  if (!url) return url;
+
+  if (!/^https?:\/\//.test(url)) {
+    return `http://${url}`;
+  }
+
+  return url;
+};