refactor: 필수 질문을 모두 확인하도록 수정 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2024 22:43
- useSendAppliction -> useApplication - canNext -> canApplicationNext(in useApplication) - remove when no data in getApplicationValues
loopy-lim
commented
Mar 6, 2024
Comment on lines
+32
to
+51
| switch (name) { | ||
| case "personalInformationAgreeForPortfolio": | ||
| case "personalInformationAgree": | ||
| return localStorageValueFromName !== "동의합니다." | ||
| ? "personalInformationAgree" | ||
| : ""; | ||
| case "email": | ||
| return !isEmail(localStorageValueFromName) ? "email" : ""; | ||
| case "check": | ||
| return localStorageValueFromName !== "확인했습니다" ? "check" : ""; | ||
| case "channel": | ||
| return localStorageValueFromName.length === 0 && | ||
| localStorage.get("channelEtc", EMPTY_STRING).length === 0 | ||
| ? "channel" | ||
| : ""; | ||
| default: | ||
| return localStorageValueFromName.length === 0 ? name : ""; | ||
| } | ||
| }) | ||
| .filter((name) => name.length !== 0); |
There was a problem hiding this comment.
먼가 좀 더 좋은 방법이 없을가요?
baegyeong
approved these changes
Mar 6, 2024
2yunseong
approved these changes
Mar 6, 2024
Comment on lines
+32
to
+51
| switch (name) { | ||
| case "personalInformationAgreeForPortfolio": | ||
| case "personalInformationAgree": | ||
| return localStorageValueFromName !== "동의합니다." | ||
| ? "personalInformationAgree" | ||
| : ""; | ||
| case "email": | ||
| return !isEmail(localStorageValueFromName) ? "email" : ""; | ||
| case "check": | ||
| return localStorageValueFromName !== "확인했습니다" ? "check" : ""; | ||
| case "channel": | ||
| return localStorageValueFromName.length === 0 && | ||
| localStorage.get("channelEtc", EMPTY_STRING).length === 0 | ||
| ? "channel" | ||
| : ""; | ||
| default: | ||
| return localStorageValueFromName.length === 0 ? name : ""; | ||
| } | ||
| }) | ||
| .filter((name) => name.length !== 0); |
|
사실 보내는 함수쪽이 좀 긴거 같아요..... 여기서 몇개 빼서 순수함수처럼 만들 수 있으니 그걸 활용해야겠어요 |
|
일단 오늘 내로 처리해야하는 문제라 닫겠습니다. 추후 리뷰 해주시면, 다시 열어서 고치겠습니다! |
bada308
reviewed
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
리뷰어에게...
관련 이슈