fix: 기획자 포트폴리오가 보이지 않는 문제 해결 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb0123
reviewed
Sep 16, 2024
| return ( | ||
| <> | ||
| <Txt typography="h4">포트폴리오</Txt> | ||
| <div className="flex gap-4"> | ||
| <div className="flex-1 flex flex-col"> | ||
| <Txt typography="h6">링크</Txt> | ||
| <Txt typography="h6">링크(개발자)</Txt> |
There was a problem hiding this comment.
링크는 개발자 뿐만 아니라 디자이너, 기획자도 작성할 수 있는데 개발자라는 단어를 넣은 이유가 궁금합니다 !
There was a problem hiding this comment.
오 그러네요 제가 수정하면서 착각했습니다 체크 감사합니다!
geongyu09
approved these changes
Sep 16, 2024
| {!!fileUrlForPlanner && ( | ||
| <div className="flex-1 flex flex-col"> | ||
| <Txt typography="h6">이번 학기 프로젝트 기획서</Txt> | ||
| {fileUrlForPlanner.map((url: string, index: number) => { |
There was a problem hiding this comment.
해당 부분은 타입추론이 되는 부분이라고 생각이 듭니다!
혹시 해당 부분 타입을 명시하진 이유가 있나요??
There was a problem hiding this comment.
레거시가 applicantDataFinder를 사용하는데, 이 함수가 any를 반환하고 있어서 일단 기존 코드 스타일 그대로 따라갔습니다 ㅠ
There was a problem hiding this comment.
하하... 죄송합니다..... 레거시를 남겨두었네요 ㅠㅠ
loopy-lim
reviewed
Sep 16, 2024
| {!!fileUrlForPlanner && ( | ||
| <div className="flex-1 flex flex-col"> | ||
| <Txt typography="h6">이번 학기 프로젝트 기획서</Txt> | ||
| {fileUrlForPlanner.map((url: string, index: number) => { |
There was a problem hiding this comment.
하하... 죄송합니다..... 레거시를 남겨두었네요 ㅠㅠ
smb0123
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
AS-IS
TO-BE
리뷰어에게...
fileUrlforPlanner를 Portfolio 컴포넌트에서 읽어올 수 있도록 수정하였습니다.관련 이슈