This repository was archived by the owner on Jun 5, 2022. It is now read-only.
Loading UploadIcon.svg with Data URI in CSS #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting the <svg> icon to it's Data URI format and using that url in CSS instead. Wbpack crashes in create-react-app when trying to parse background: url(UploadImage.css) as it cannot find a suitable loader.
joshuaai
added a commit
to joshuaai/react-images-upload
that referenced
this pull request
Mar 31, 2018
This keeps the original SVG file rather than inlining it as in JakeHartnell#23. The image is passed instead as a the `src` property to <img />. This fixes JakeHartnell#22.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the
<svg>icon to it's Data URI format and using that url inthe CSS file instead. Webpack crashes in
create-react-appwhen trying to parsebackground: url(UploadIcon.svg)as it cannot find a suitable loader.This fixes #21