Skip to content

chore: remove dead code#99

Merged
JarbasAl merged 1 commit into
devfrom
dead
Mar 23, 2026
Merged

chore: remove dead code#99
JarbasAl merged 1 commit into
devfrom
dead

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Mar 23, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Removed deprecated encoding re-exports (Z85B, Z85P, B91). Users should migrate directly to the z85base91 package for these encodings.
    • Removed internal encoding benchmark utilities.

@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3dd92939-4039-45b6-a41c-7c108c88695f

📥 Commits

Reviewing files that changed from the base of the PR and between 2b7bc28 and f089d7a.

📒 Files selected for processing (6)
  • hivemind_bus_client/encodings/__init__.py
  • hivemind_bus_client/encodings/b91.py
  • hivemind_bus_client/encodings/benchmark.py
  • hivemind_bus_client/encodings/z85b.py
  • hivemind_bus_client/encodings/z85p.py
  • hivemind_bus_client/z85b.py
💤 Files with no reviewable changes (6)
  • hivemind_bus_client/encodings/b91.py
  • hivemind_bus_client/encodings/z85p.py
  • hivemind_bus_client/encodings/z85b.py
  • hivemind_bus_client/encodings/init.py
  • hivemind_bus_client/z85b.py
  • hivemind_bus_client/encodings/benchmark.py

📝 Walkthrough

Walkthrough

This pull request removes deprecated encoding modules and deprecation shims that directed users to migrate to the external z85base91 package. The changes eliminate redundant re-exports, deprecation warnings, and a benchmarking utility module.

Changes

Cohort / File(s) Summary
Encoding re-export shims
hivemind_bus_client/encodings/__init__.py, hivemind_bus_client/encodings/z85b.py, hivemind_bus_client/encodings/z85p.py, hivemind_bus_client/encodings/b91.py
Removed deprecated import shims and module-level deprecation warnings that previously re-exported Z85B, Z85P, and B91 from z85base91 package.
Root-level encoding shim
hivemind_bus_client/z85b.py
Removed deprecated module that emitted import-time deprecation warning for Z85B re-export.
Benchmark utility module
hivemind_bus_client/encodings/benchmark.py
Removed entire benchmarking module including SupportedEncodings enum, encoder/decoder factory functions, performance measurement utilities, score calculation logic, and Click CLI entrypoint.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Old shimmer shims have had their day,
Deprecation warnings fade away,
To z85base91 we say "good-bye!"
Cleaner code now stands up high! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove dead code' accurately describes the main change: removal of deprecated modules and functions that are no longer needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dead

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JarbasAl JarbasAl merged commit 59342e3 into dev Mar 23, 2026
2 checks passed
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown

Systems nominal. Checks complete. 🛸

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

The repo's annual physical is complete! 🩺

⚠️ Some required files are missing.

Latest Version: 0.5.0a5

hivemind_bus_client/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
setup.py — setup.py
CHANGELOG.md — Changelog
requirements.txt — Requirements
hivemind_bus_client/version.py has valid version block markers

📊 Coverage

Diving deep into the code to see what's covered! 🤿

⚠️ Coverage data unavailable — check the job log.

⚠️ Some tests failed — coverage figures may be incomplete.

🏷️ Release Preview

I've checked the 'Internal Changes' section. ⚙️

Current: 0.5.0a5Next: 0.5.0a6

Signal Value
Label (none)
PR title chore: remove dead code
Bump alpha

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.5.0a6

Channel Status Note Current Constraint
Stable Not in channel -
Testing Compatible hivemind-bus-client>=0.4.4,<1.0.0
Alpha Compatible hivemind-bus-client>=0.4.6a2

🔍 Lint

A detailed summary of the latest automation run. 📝

ruff: issues found — see job log

🔨 Build Tests

I've checked the welds on your new features. 👨‍🏭

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

❌ 3.10: python -m build failed
❌ 3.11: python -m build failed
❌ 3.12: python -m build failed
❌ 3.13: python -m build failed
❌ 3.14: python -m build failed
Check job logs for details.


The silent guardian of the dev branch. 🦇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant