feat: add endpoint that streams and increments#15
Open
thatonecodes wants to merge 1 commit intoJasonLovesDoggo:mainfrom
Open
feat: add endpoint that streams and increments#15thatonecodes wants to merge 1 commit intoJasonLovesDoggo:mainfrom
thatonecodes wants to merge 1 commit intoJasonLovesDoggo:mainfrom
Conversation
- Added a new `/stream/hit` endpoint that increments the counter before streaming data - Updated `docs/index.html` to include the new endpoint information and a basic example - Added test coverage for `/stream/hit` in `stream_test.go` - Registered the route in `main.go`, and handled logic in `routes.go`
Owner
|
Sorry that I never commented. My only real concern is the amount of code duplication here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14.
This implementation is open to any changes, this just seemed like the easiest way to go about things.
Summary
/stream/hitendpoint that increments the counter before streaming datadocs/index.htmlto include the new endpoint information and a basic example/stream/hitinstream_test.gomain.go, and handled logic inroutes.go