Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V8 to 10.0.139.9 #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update V8 to 10.0.139.9 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Source/Noesis.Javascript/JavaScript.Net.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\..\packages\v8-v143-x64.9.8.177.4\build\native\v8-v143-x64.props" Condition="Exists('..\..\packages\v8-v143-x64.9.8.177.4\build\native\v8-v143-x64.props')" />
<Import Project="..\..\packages\v8.redist-v143-x64.9.8.177.4\build\native\v8.redist-v143-x64.props" Condition="Exists('..\..\packages\v8.redist-v143-x64.9.8.177.4\build\native\v8.redist-v143-x64.props')" />
<Import Project="..\..\packages\v8-v143-x86.9.8.177.4\build\native\v8-v143-x86.props" Condition="Exists('..\..\packages\v8-v143-x86.9.8.177.4\build\native\v8-v143-x86.props')" />
<Import Project="..\..\packages\v8.redist-v143-x86.9.8.177.4\build\native\v8.redist-v143-x86.props" Condition="Exists('..\..\packages\v8.redist-v143-x86.9.8.177.4\build\native\v8.redist-v143-x86.props')" />
<Import Project="..\..\packages\v8-v143-x86.10.0.139.9\build\native\v8-v143-x86.props" Condition="Exists('..\..\packages\v8-v143-x86.10.0.139.9\build\native\v8-v143-x86.props')" />
<Import Project="..\..\packages\v8.redist-v143-x86.10.0.139.9\build\native\v8.redist-v143-x86.props" Condition="Exists('..\..\packages\v8.redist-v143-x86.10.0.139.9\build\native\v8.redist-v143-x86.props')" />
<Import Project="..\..\packages\v8-v143-x64.10.0.139.9\build\native\v8-v143-x64.props" Condition="Exists('..\..\packages\v8-v143-x64.10.0.139.9\build\native\v8-v143-x64.props')" />
<Import Project="..\..\packages\v8.redist-v143-x64.10.0.139.9\build\native\v8.redist-v143-x64.props" Condition="Exists('..\..\packages\v8.redist-v143-x64.10.0.139.9\build\native\v8.redist-v143-x64.props')" />
<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|Win32">
<Configuration>Debug</Configuration>
Expand Down Expand Up @@ -183,9 +183,9 @@
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\..\packages\v8.redist-v143-x86.9.8.177.4\build\native\v8.redist-v143-x86.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8.redist-v143-x86.9.8.177.4\build\native\v8.redist-v143-x86.props'))" />
<Error Condition="!Exists('..\..\packages\v8-v143-x86.9.8.177.4\build\native\v8-v143-x86.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8-v143-x86.9.8.177.4\build\native\v8-v143-x86.props'))" />
<Error Condition="!Exists('..\..\packages\v8.redist-v143-x64.9.8.177.4\build\native\v8.redist-v143-x64.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8.redist-v143-x64.9.8.177.4\build\native\v8.redist-v143-x64.props'))" />
<Error Condition="!Exists('..\..\packages\v8-v143-x64.9.8.177.4\build\native\v8-v143-x64.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8-v143-x64.9.8.177.4\build\native\v8-v143-x64.props'))" />
<Error Condition="!Exists('..\..\packages\v8.redist-v143-x64.10.0.139.9\build\native\v8.redist-v143-x64.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8.redist-v143-x64.10.0.139.9\build\native\v8.redist-v143-x64.props'))" />
<Error Condition="!Exists('..\..\packages\v8-v143-x64.10.0.139.9\build\native\v8-v143-x64.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8-v143-x64.10.0.139.9\build\native\v8-v143-x64.props'))" />
<Error Condition="!Exists('..\..\packages\v8.redist-v143-x86.10.0.139.9\build\native\v8.redist-v143-x86.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8.redist-v143-x86.10.0.139.9\build\native\v8.redist-v143-x86.props'))" />
<Error Condition="!Exists('..\..\packages\v8-v143-x86.10.0.139.9\build\native\v8-v143-x86.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\v8-v143-x86.10.0.139.9\build\native\v8-v143-x86.props'))" />
</Target>
</Project>
2 changes: 1 addition & 1 deletion Source/Noesis.Javascript/JavascriptContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ CompileScript(v8::Isolate *isolate, wchar_t const *source_code, wchar_t const *r
else
{
Local<String> resource = String::NewFromTwoByte(isolate, (uint16_t const *)resource_name, v8::NewStringType::kNormal).ToLocalChecked();
ScriptOrigin *origin = new ScriptOrigin(resource);
ScriptOrigin *origin = new ScriptOrigin(isolate, resource);
script = Script::Compile(JavascriptContext::GetCurrentIsolate()->GetCurrentContext(), source, origin);
}

Expand Down
8 changes: 4 additions & 4 deletions Source/Noesis.Javascript/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="v8.redist-v143-x64" version="9.8.177.4" targetFramework="native" />
<package id="v8.redist-v143-x86" version="9.8.177.4" targetFramework="native" />
<package id="v8-v143-x64" version="9.8.177.4" targetFramework="native" />
<package id="v8-v143-x86" version="9.8.177.4" targetFramework="native" />
<package id="v8.redist-v143-x64" version="10.0.139.9" targetFramework="native" />
<package id="v8.redist-v143-x86" version="10.0.139.9" targetFramework="native" />
<package id="v8-v143-x64" version="10.0.139.9" targetFramework="native" />
<package id="v8-v143-x86" version="10.0.139.9" targetFramework="native" />
</packages>