Various fixes #25
Open
Various fixes #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to edition 2018
mitchmindtree
approved these changes
Jan 19, 2021
Contributor
mitchmindtree
left a comment
mitchmindtree
left a comment
There was a problem hiding this comment.
Looks good to me, mostly appears to be a cargo fmt run and some clippy improvements, but also refactors PrimarySource from an enum to a struct with associated consts rather than variants.
| pub const OPPS: PrimarySource = PrimarySource(code_to_u32!(b"OPPS")); | ||
| pub const FREE: PrimarySource = PrimarySource(code_to_u32!(b"FREE")); | ||
| pub const INIT: PrimarySource = PrimarySource(code_to_u32!(b"INIT")); | ||
| pub const NULL: PrimarySource = PrimarySource(0); |
Contributor
There was a problem hiding this comment.
Just thought I'd mention you can also use pub const NULL: Self = Self(0);, etc which can make future refactoring a little easier, but doesn't really matter.
Coding-Badly
pushed a commit
to gremlin/ntp
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.