-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Version 1.1.0 Overhaul - Resture Codebase #18
Conversation
Fix leash event not working Fix invalid plugin instance with MessageTranslations
Rename listeners
Just a note for this, the help message along with various other messages are currently broken due to the conversion from the legacy Bukkit logging to the Kyori Component message logging. This will be fixed ASAP and when it is, it should be good to merge |
Some updates on this PR. The migrations to the message components will be the final change in this PR. The movement to the custom GUI system that isn't completed yet will be pushed alongside the 1.1.1 update. |
Update config with new MiniMessage support
^ Colour translations aren't done yet as the GUI listener seems to have some funky checking for the display name of the item clicked. I will just do the overhaul for the listener now while I'm at it |
Clean up menu click listener
Description
Restructured the entire codebase:
Moving Forward..
We should aim to fix the usage of Kyori component messages, I'm not a super big fan of converting the hex in messages to their Bukkit colour counterparts. Additionally, the GUI needs to be migrated to the new system, along with this is the removal of the MenuHandlers listener. Hence why there were little to no changes to the menu handlers. FInally, I feel that some classes do still need to be reorganized/renamed/refactored. I did my best to refractor the variables as best as possible so we should be good variable-wise.
Type of change
How Has This Been Tested?
N/A
Checklist: