Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Version 1.1.0 Overhaul - Resture Codebase #18

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

IanTapply22
Copy link
Member

Description

Restructured the entire codebase:

  • Converted the entire message system to use Kyori message components
  • Moved files around to remove "data" directory
  • Incremented pom.xml file version
  • Converted to the newly implemented Logger
  • Renamed "BalloonOwner" to be "SingleBalloon" in preparation for multi-part balloons
  • Created a GUI core -> TODO: Will be implemented/migrated in this PR
  • Reanemd some utilities to make more sense
  • Updated main Bloons plugin class to use the new Listener manager/cleaned it up
  • Fixed all references of variables in an instance to use "this"
  • Fix some random checks that were unneeded
  • Commented everything I could in the codebase
  • Created a custom NBTItem object that extends ItemStack to make it easier to store NBT data on items
  • Created a BalloonConfiguration class with static final IDs for the balloon entities

Moving Forward..

We should aim to fix the usage of Kyori component messages, I'm not a super big fan of converting the hex in messages to their Bukkit colour counterparts. Additionally, the GUI needs to be migrated to the new system, along with this is the removal of the MenuHandlers listener. Hence why there were little to no changes to the menu handlers. FInally, I feel that some classes do still need to be reorganized/renamed/refactored. I did my best to refractor the variables as best as possible so we should be good variable-wise.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes

@IanTapply22 IanTapply22 added bug Something isn't working enhancement New feature or request labels Jun 7, 2024
@IanTapply22 IanTapply22 self-assigned this Jun 7, 2024
Fix leash event not working

Fix invalid plugin instance with MessageTranslations
Rename listeners
@IanTapply22
Copy link
Member Author

Just a note for this, the help message along with various other messages are currently broken due to the conversion from the legacy Bukkit logging to the Kyori Component message logging. This will be fixed ASAP and when it is, it should be good to merge

@IanTapply22
Copy link
Member Author

Some updates on this PR. The migrations to the message components will be the final change in this PR. The movement to the custom GUI system that isn't completed yet will be pushed alongside the 1.1.1 update.

Update config with new MiniMessage support
@IanTapply22
Copy link
Member Author

^ Colour translations aren't done yet as the GUI listener seems to have some funky checking for the display name of the item clicked. I will just do the overhaul for the listener now while I'm at it

Clean up menu click listener
@IanTapply22 IanTapply22 mentioned this pull request Jun 7, 2024
8 tasks
@IanTapply22 IanTapply22 changed the title Version 1.1.0 Overhaul - Resture Codebase feat: Version 1.1.0 Overhaul - Resture Codebase Jun 7, 2024
@IanTapply22 IanTapply22 merged commit 184d3a0 into main Jun 7, 2024
4 checks passed
@IanTapply22 IanTapply22 deleted the version-1.1.0-overhaul branch June 7, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants