Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MEG (ModelEngine) Support #37

Closed
wants to merge 40 commits into from
Closed

Implement MEG (ModelEngine) Support #37

wants to merge 40 commits into from

Conversation

IanTapply22
Copy link
Member

@IanTapply22 IanTapply22 commented Jun 20, 2024 •
edited by jeqostudios
Loading

Description

Implement model engine support to allow multipart balloon segments to be entity models

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on a version 1.20.4 PaperMC Minecraft server using the default Minecraft JAR as a client

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes- [ ]

IanTapply22 added 30 commits June 19, 2024 14:08
Create defaults for new configuration structure
82ec001
Create comments in example balloon configuration folder
122bc41 
Start rework of ConfigConfiguration class

Create constructor for single balloon types
Create configuration helpers to get all balloon types
fce820a
Renamed balloon array in balloon core
f79db20 
Made methods static in config configuration
Create helpers to manage single balloons in balloon core
f7d3f35
Adapt command core to new configuration changes
643d120
Fix equip command to conform with configuration changes
54b9b11 
Fix instancing usage from balloon core
Finalize the initial changes to change configuration structure
0d4ae26
Polished up some random instancing issues across the plugin
60d64b9
Create a fix for example files not beign transferred over
bf64ce9
Fix retrieving of all balloon types
fb90ef4 
Fix tab completer completions
Fix parsing of permissions and causing NPE
6eba35d
Remove some configuration parsing that shouldn't be happening
093f7c1
Fix returning after color is not set
b9b9462
Nest the color checks inside of the initial ones
0827e17
Fixed some balloons being omitted if in side slot of GUI
2a8f91a
Fixed some returned values being null and causing issues
005b0ac 
Moved tab complete options of balloons to separate method
Fix more return values being null
2fd4a1b 
Added proper comments to every command

Utilized ConfigConfiguration constants
Modify shutdown and enable message logger messages to hold more infor…
e5870ba 
…mation
Fix custom model data values for GUI
20d99d1
Remove constant logging of processing files message
e0652fc 
Fix leads from multipart balloons dropping upon spawn

Fixed permission issues for equip command
Fix leads breaking on multipart balloons
aa7900f 
Removed unneeded leash holder setting
Fixed leads not being centered on head segment
cbd33bd
Added customizable leash height to increase realness
0318e64
Updated default leash-height-from-player value
337966b
Change leash-height-from-player to be leash-height
382ea91
Fix single balloon lore not showing in GUI
9747700
Changed the name of the default multipart balloon
f48da66
Fix unequipping of balloons via the GUI
f758d7c
Remove all unused imports
6c30bf1
Only remove MEG model if it exists on cancel
c37eff0 
Move entire pose of armor stand to still tilt MEG entities
Modified when all poses are set of an armor stand
d41afaa 
Commented every part of this implementation for single balloons
@IanTapply22
Copy link
Member Author

This is now redundant and will now be closed in favour of #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IanTapply22 IanTapply22

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IanTapply22