Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Schedule screen (part 1) #248

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Create Schedule screen (part 1) #248

merged 3 commits into from
Feb 3, 2025

Conversation

zsmb13
Copy link
Contributor

@zsmb13 zsmb13 commented Jan 29, 2025

Adds the initial implementation for the schedule screen. First PR of multiple, so that we don't need to review all of this in a single go.

Includes:

  • A ViewModel for the sessions screen, offloading the list calculation operations to background threads
  • Displaying the list of sessions
  • Session feedback handling
  • The top Day buttons skipping to the appropriate days (and updating based on scroll state)
  • Filtering for bookmarked only
  • Entering search mode, filtering for names and session titles, with handling of diacritics
  • In search mode, filtering by tags

TODOs remaining (also in the code):

  • The "Now" button for the header
  • Displaying when a session is coming up soon or currently live
  • Highlighting workshops in a separate scroller at the top
  • Service events
  • Filtering tags being based on real data instead of hardcoded values
  • Some improvements on date and string handling (currently too hardcoded)
  • State preservation around navigation
Screen.Recording.2025-02-02.at.22.39.36.mov

@zsmb13 zsmb13 force-pushed the screens/schedule branch 3 times, most recently from c62909a to 28f6bca Compare January 29, 2025 23:49
@zsmb13 zsmb13 force-pushed the screens/schedule branch 6 times, most recently from c8e8794 to 213513d Compare February 2, 2025 21:41
@zsmb13 zsmb13 changed the title WIP Screens/schedule Create Schedule screen (part 1) Feb 2, 2025
@zsmb13 zsmb13 marked this pull request as ready for review February 2, 2025 21:51
@zsmb13 zsmb13 requested review from kropp and e5l February 2, 2025 21:51
Base automatically changed from screens/settings to kotlinconf-2025 February 2, 2025 21:51
Copy link
Member

@kropp kropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor comments, and there are a bunch of TODOs in the code, but given that it is just the first part of a bigger PR, I assume it is okay.

@zsmb13 zsmb13 merged commit f342000 into kotlinconf-2025 Feb 3, 2025
5 checks passed
@zsmb13 zsmb13 deleted the screens/schedule branch February 3, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants