Use kotlinx.datetime for time handling #272
Conversation
zsmb13
force-pushed
the
kotlinx-datetime
branch
2 times, most recently
from
4e46b1f to
f5120a1
Compare
zsmb13
force-pushed
the
kotlinx-datetime
branch
9 times, most recently
from
228ef82 to
b917dbd
Compare
zsmb13
changed the title
zsmb13
force-pushed
the
kotlinx-datetime
branch
from
b917dbd to
d077a3a
Compare
| val isLightning: Boolean = endsAt - startsAt <= LIGHTNING_TALK_LIMIT | ||
| } | ||
|
|
||
| val SessionCardView.isLive get() = state == SessionState.Live | ||
| val SessionCardView.isUpcoming get() = state == SessionState.Upcoming | ||
| val SessionCardView.isPast get() = state == SessionState.Past | ||
|
|
||
| val Session.isLightning: Boolean get() = endsAt.timestamp - startsAt.timestamp <= 15 * 60 * 1000 | ||
| val Session.isLightning: Boolean | ||
| get() = endsAt - startsAt <= LIGHTNING_TALK_LIMIT |
There was a problem hiding this comment.
minor: isLightning check is duplicated
There was a problem hiding this comment.
We need this both on Session and SessionCardView, I think with the limit variable extracted at least it's alright like this
| import java.time.Clock | ||
| import java.time.LocalDateTime |
There was a problem hiding this comment.
The backend code still uses java.time APIs in a bunch of places, I tried touching as little of the backend code as possible. Only edited the parts that were tightly coupled to the shared code.
We could rewrite the backend to be all kotlinx.datetime too, but it's not strictly necessary. Just wanted to have these types on the client side instead of using the Ktor GMTDate type everywhere.
@e5l to review the backend changes though, and whether we want more of them.
There was a problem hiding this comment.
Feel free to use kotlinx.datetime if it's possible
There was a problem hiding this comment.
Okay, then I think it is fine to merge this PR as is and log an issue for backend refactoring.
| import java.time.Clock | ||
| import java.time.LocalDateTime |
There was a problem hiding this comment.
Feel free to use kotlinx.datetime if it's possible
zsmb13
force-pushed
the
kotlinx-datetime
branch
from
d077a3a to
1b57a7a
Compare
zsmb13
force-pushed
the
kotlinx-datetime
branch
from
1b57a7a to
e986d67
Compare
No description provided.