Add view for unverified protector#4158
Open
agnieszkajarosikloj wants to merge 16 commits into
Open
Conversation
|
|
agnieszkajarosikloj
force-pushed
the
feature/4125-verify-banner
branch
from
373a190 to
385fe33
Compare
agnieszkajarosikloj
force-pushed
the
feature/4125-verify-banner
branch
from
385fe33 to
7c41994
Compare
Base automatically changed from
feature/4125-verify-banner
to
feature/4126-sidebar-locked
March 6, 2023 14:34
arrenv
requested changes
Mar 8, 2023
arrenv
left a comment
arrenv
left a comment
Member
There was a problem hiding this comment.
Thanks @agnieszkajarosikloj
Mostly looks good, just a few comments, which is not isolated to this PR.
Comment on lines
+82
to
+84
| icon: <Icon name="usd-coin" appearance={{ size: 'medium' }} />, | ||
| amount: '5,300', | ||
| currency: 'USDC', |
Member
There was a problem hiding this comment.
These should be in a constants file.
Comment on lines
+99
to
+102
| icon: <Icon name="usd-coin" appearance={{ size: 'medium' }} />, | ||
| amount: '3,800 / year', | ||
| currency: 'USDC', | ||
| }} |
Member
There was a problem hiding this comment.
These should be in a constants file.
Comment on lines
+109
to
+111
| icon: <Icon name="usd-coin" appearance={{ size: 'medium' }} />, | ||
| amount: '3,800 / year', | ||
| currency: 'USDC', |
Member
There was a problem hiding this comment.
These should be in a constants file.
Comment on lines
+92
to
+94
| icon: <Icon name="usd-coin" appearance={{ size: 'medium' }} />, | ||
| amount: '5,300', | ||
| currency: 'USDC', |
Member
There was a problem hiding this comment.
These should be in a constants file.
agnieszkajarosikloj
force-pushed
the
feature/4131-view-for-unverified-protector
branch
from
ed64f75 to
085b5dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds view for user who is nominated as a protector and has not been verified yet.
To test this view go to /incorporation/create route and fill in the form. Nominate yourself as protector.
When you confirm the form you should see a banner with verify and remove buttons. You will also see the status (unverified) next to your name in the list of protectors. Status is a mock.
To test the view for non-nominated users, do not add yourself as a protector. After submitting the form, the appropriate labels should appear next to the fields with listed protectors. When you are not nominated, you should not see the banner with Remove and Verify buttons.
Figma link
Resolves #4131