Bump clang-format version to 10-12 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
pgrete
changed the title
|
@pgrete so sorry, I didn't see this, I get spammed with so many emails. I just now saw this issue, I'm guessing you simply created a fork. |
I did and give that I had to update some other pieces in the CI infrastructure as well, the change to Parthenon was minimal. |
|
Would you mind moving this repo @JoshuaSBrown (so that I could get rid of my fork) or should I move my fork? |
|
@pgrete, if I cannot address this within a month I'll recommend you move the fork. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JoshuaSBrown
I'm trying to bump the clang-format versions for parthenon.
If you're happy that this still lives in "your" repo, then you could try accepting the PR (and trigger the other machinery so that things get updated).
If you prefer that I keep the changes in a fork, I'm also happy to do so.