Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testing properly #214

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Disable testing properly #214

merged 2 commits into from
Apr 12, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Apr 12, 2024

Wasted some time trying to understand what test/runtests.jl actually does (after recovering a functioning Project.toml) and why CI.yml is disabled (commented out).

Here's the reason, from a comment in /test/runtests.jl added in this PR:

# This file was originally developed to test that each tutorial.jl file could be
# executed. When written, all tutorials were based on a *single* Manifest.toml, appearing
# at the top level. But now each tutorial get's it's own environment and the approach
# taken here does not work.

After this PR, you can now run Pkg.test("DataScienceTutorials") without weird output, but it executes no actual testing and prints a warning explaining the current situation.

Will open PR shortly to flag the lack of automated testing.

This PR also adds /Manifest.toml to .gitignore and removes this top level Manifest.toml, which is not attached to any tutorial, but used only locally for developers (e.g., for include("deploy.jl")).

@EssamWisam
Copy link
Collaborator

Looks good. Thanks.

@EssamWisam EssamWisam merged commit 52732d3 into master Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants