make sure that nullfunc is not ellided#164
Merged
Conversation
jrevels
approved these changes
Apr 19, 2020
Member
jrevels
left a comment
There was a problem hiding this comment.
TIL about Base.inferencebarrier, that's a dope little addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #163
We don't use these functions by default to estimate the overhead,
but right now they give the answer of:
Which is not a particular helpful estimate of the costs. With
a inference barrier we have a for-loop and a call to a function.
We explicitly note in https://github.com/JuliaCI/BenchmarkTools.jl/blob/master/doc/manual.md#understanding-compiler-optimizations
that compiler optimizations like that have to be accounted for by the user
This is more accurate and seems more stable, but requires a large number
of iterations to converge, probably means we should revitalize #94.