-
Notifications
You must be signed in to change notification settings - Fork 89
changed: bump ForwardDiff
compat in ControlSystems
+ ControlSystemsBase
also
#978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ForwardDiff
in ControlSystems
+ ControlSystemsBase
alsoForwardDiff
compat in ControlSystems
+ ControlSystemsBase
also
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 41 41
Lines 4981 4981
=======================================
Hits 4603 4603
Misses 378 378 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Weird it does not pass locally but it passes here. Oh well, good news XP |
Did you verify that the tests actually ran with the new version? OrdinaryDiffEq might not yet be compatible so the tests might have run with an old version. BTW, I'm in Jordan 🇯🇴 on holiday with very spotty internet connections, so my response times may be long 😊 |
Forgot to answer but yes you are right the test are executed with v0.10 instead of v1.0. I'm starting to understand why the CompatHelper forces the upper bound of compat entries. But at the same time, I find hard to fully understand dependency issues. If everyone (as in every package) is waiting for everyone to update the ForwardDiff compat entries in their
And realistically, there is probably many steps before step 1. Am I misunderstanding something if I feel like "waiting for the other to update in the correct order" is almost a Mission: Impossible? edit: I will post my question on discourse, I'm probably not the only one who does not understand this part. edit2: Chris answered my quesiton here edit3: Forgot to wish you a wonderful trip to Jordan, have fun as much as you can 🇯🇴 😄 !!! |
more complete than #977
Some tests do not pass locally, but I think it was already the case before. (edit: just tested locally and yes, they were failing also before)
BTW, I can also try to do #975 myself.