Skip to content

Improve type stability #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cscherrer
Copy link

This PR makes some adjustments that aim to improve type stability. Both JET.jl and Aqua.jl seem happier after these changes. I didn't do exhaustive performance testing, but as one proxy for this...

# Before this PR
julia> @time Pkg.test()
 17.379904 seconds (264.21 k allocations: 24.215 MiB, 0.07% gc time)

# After this PR
julia> @time Pkg.test()
 13.845315 seconds (265.68 k allocations: 24.159 MiB, 0.08% gc time)
end

@codecov-commenter
Copy link

Codecov Report

Merging #12 (8c05a67) into main (2fed970) will increase coverage by 0.14%.
The diff coverage is 93.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   94.02%   94.17%   +0.14%     
==========================================
  Files           6        6              
  Lines         201      206       +5     
==========================================
+ Hits          189      194       +5     
  Misses         12       12              
Impacted Files Coverage Δ
src/core.jl 84.84% <89.47%> (+1.51%) ⬆️
src/autorun.jl 100.00% <100.00%> (ø)
src/effecthandler.jl 94.11% <100.00%> (-0.33%) ⬇️
src/instances.jl 97.46% <100.00%> (+1.21%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants