-
Notifications
You must be signed in to change notification settings - Fork 5
Prepared geometry #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asinghvi17
wants to merge
4
commits into
as/trees
Choose a base branch
from
as/prepare
base: as/trees
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prepared geometry #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f33c8e4
to
a801c2c
Compare
Merged
ee5218e
to
9d481bf
Compare
Co-authored-by: Rafael Schouten <[email protected]>
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of the trees PR, to enable prepared geometry. The idea is that we should be able to do
index = get(geometry, EdgeTreeLike, NaturalEdgeTree)
and have it give us some form of edge tree we can query.Prepared geoms will be structured as wrappers, with a single
geom
field and then a tuple of "preparations". Note that this can't influence the underlying geometry memory layout at all - althoughPrepared
will default to callingtuples
, maybe deactivated by a keywordtuples = false
.Preparations need to have a desired application trait / level. It's a bit tricky because things like STRtrees can apply at the polygon level, multipolygon level, and at the level of individual polygon rings (might be useful for things like a country with a lot of lakes).
We should be able to "get" or instantiate a preparation by
get(geom, SpatialIndexLike#=or trait=#, STRIndex)
for example, since most algorithms that can be accelerated only care that you have an accelerator, not how you got it. And the main part of the runtime is creating the index anyway.