[JSONX] Fix unicode handling when unescaping strings #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `JSONX.unescape_string()` would insert single codeunits at a time into the unescaped output (if the current character is not an escape sequence). This caused characters composed of multiple codeunits to be unescaped as individual characters.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 7 7
Lines 1330 1330
=======================================
Hits 1197 1197
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
JSONX.unescape_string()would insert single codeunits at a time into the unescaped output (if the current character is not an escape sequence). This caused characters composed of multiple codeunits to be unescaped as individual characters.Discovered by Claude when investigating JuliaLang/IJulia.jl#1071 (comment).